Pin sqlalchemy!=1.4.0#996
Merged
dwhswenson merged 2 commits intoMar 17, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 138 138
Lines 14671 14671
=======================================
Hits 11823 11823
Misses 2848 2848 Continue to review full report at Codecov.
|
Member
|
LGTM, good luck on the talk (assuming it hasn't happened already);) |
Member
Author
|
Going on in a half hour -- almost forgot to merge this first! (It's a conference in the US, so I'm speaking at 11pm local.) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests stopped working this morning (had to be the day of my APS March Meeting talk!) SQLAlchemy accidentally made changes in their 1.4.0 release that broke SimStore. See sqlalchemy/sqlalchemy#6074. Looks like they're already preparing a fix, so I'm pinning to
!=1.4.0as opposed to<1.4.