Skip to content

Fix impression sent from feature experiment variation toggled off.#193

Merged
mikeproeng37 merged 1 commit into
masterfrom
mng/fix-feature-exp-impression
Jun 19, 2018
Merged

Fix impression sent from feature experiment variation toggled off.#193
mikeproeng37 merged 1 commit into
masterfrom
mng/fix-feature-exp-impression

Conversation

@mikeproeng37

Copy link
Copy Markdown
Contributor

No description provided.

@tylerbrandt

Copy link
Copy Markdown
Contributor

build

@tylerbrandt

Copy link
Copy Markdown
Contributor

updated compat suite branch

@coveralls

coveralls commented Jun 19, 2018

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 537

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 89.049%

Totals Coverage Status
Change from base Build 534: 0.004%
Covered Lines: 2220
Relevant Lines: 2493

💛 - Coveralls

@aliabbasrizvi aliabbasrizvi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Verify {@link Optimizely#isFeatureEnabled(String, String)} calls into
* {@link Optimizely#isFeatureEnabled(String, String, Map)} and they both
* return False
* when the user is bucketed an feature test variation that is turned off.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in and not an

@mikeproeng37

Copy link
Copy Markdown
Contributor Author

build

3 similar comments
@mikeproeng37

Copy link
Copy Markdown
Contributor Author

build

@mikeproeng37

Copy link
Copy Markdown
Contributor Author

build

@tylerbrandt

Copy link
Copy Markdown
Contributor

build

@mikeproeng37 mikeproeng37 merged commit f5b9516 into master Jun 19, 2018
tylerbrandt pushed a commit that referenced this pull request Jun 19, 2018
* Fix impression sent from feature experiment variation toggled off. (#193)
tylerbrandt pushed a commit that referenced this pull request Jun 19, 2018
* Fix impression sent from feature experiment variation toggled off. (#193)
@aliabbasrizvi aliabbasrizvi deleted the mng/fix-feature-exp-impression branch August 10, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants