Skip to content

refac(ci): (adding python 3.7 support fix) only xenial for 3.7#160

Merged
juancarlostong merged 1 commit into
oakbani/python-3.7-supportfrom
jctong/python-3.7-support-alt
Jan 9, 2019
Merged

refac(ci): (adding python 3.7 support fix) only xenial for 3.7#160
juancarlostong merged 1 commit into
oakbani/python-3.7-supportfrom
jctong/python-3.7-support-alt

Conversation

@juancarlostong

@juancarlostong juancarlostong commented Jan 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adding python3.7 support. Ubuntu Trusty does not support this version so we have to use Xenial instead.

Note

@juancarlostong juancarlostong added the wip Work in progress label Jan 7, 2019
@juancarlostong juancarlostong force-pushed the jctong/python-3.7-support-alt branch from ead374a to 7afe7e0 Compare January 7, 2019 22:51
@coveralls

coveralls commented Jan 7, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 7afe7e0 on jctong/python-3.7-support-alt into bbb8cc2 on oakbani/python-3.7-support.

3 similar comments
@coveralls

coveralls commented Jan 7, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 7afe7e0 on jctong/python-3.7-support-alt into bbb8cc2 on oakbani/python-3.7-support.

@coveralls

coveralls commented Jan 7, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 7afe7e0 on jctong/python-3.7-support-alt into bbb8cc2 on oakbani/python-3.7-support.

@coveralls

coveralls commented Jan 7, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 7afe7e0 on jctong/python-3.7-support-alt into bbb8cc2 on oakbani/python-3.7-support.

@coveralls

coveralls commented Jan 7, 2019 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 50a9f22 on jctong/python-3.7-support-alt into bbb8cc2 on oakbani/python-3.7-support.

@juancarlostong juancarlostong force-pushed the jctong/python-3.7-support-alt branch 2 times, most recently from bf19e64 to fbb4e33 Compare January 7, 2019 22:56
@juancarlostong juancarlostong changed the title only xenial for 3.7 refac(ci): (adding python 3.7 support fix) only xenial for 3.7 Jan 7, 2019
@juancarlostong juancarlostong force-pushed the jctong/python-3.7-support-alt branch from fbb4e33 to 8c569f9 Compare January 7, 2019 23:18
@juancarlostong juancarlostong removed the wip Work in progress label Jan 7, 2019
@juancarlostong juancarlostong mentioned this pull request Jan 7, 2019
Closed
aliabbasrizvi
aliabbasrizvi approved these changes Jan 8, 2019
View reviewed changes

@aliabbasrizvi aliabbasrizvi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .travis.yml Outdated
@juancarlostong juancarlostong force-pushed the jctong/python-3.7-support-alt branch from 8c569f9 to 50a9f22 Compare January 8, 2019 19:15
@aliabbasrizvi

aliabbasrizvi commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

Going to merge this.

@juancarlostong juancarlostong merged commit 7d0873d into oakbani/python-3.7-support Jan 9, 2019
@juancarlostong juancarlostong deleted the jctong/python-3.7-support-alt branch January 9, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

2 more reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juancarlostong @coveralls @aliabbasrizvi @msohailhussain