Update dependencies to support go 1.18+#54
Merged
Conversation
odeke-em
approved these changes
Jul 7, 2022
odeke-em
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you @SaveTheRbtz!
kirbyquerby
suggested changes
Jul 7, 2022
kirbyquerby
left a comment
There was a problem hiding this comment.
Thanks for the PR! You should be able to get tests to pass by updating the Go version to 1.18 in the workflow and go.mod:
structslop/.github/workflows/go.yaml
Line 17 in 4d89acb
Line 3 in 4d89acb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the update it was failing with: