Conversation
alianam
approved these changes
Nov 4, 2021
kleinjm
reviewed
Nov 4, 2021
| self.assertEqual(project.developer, "Patch Sandbox Supplier Test") | ||
| self.assertIsInstance(project.country, str) | ||
| self.assertIsInstance(project.type, str) | ||
| self.assertIsInstance(project.developer, str) |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, that data was too sparsely populated to make for a reliable test. To be revised when we can improve test strategies for SDKs.
kleinjm
approved these changes
Nov 4, 2021
pcothenet
commented
Nov 4, 2021
Comment on lines
-75
to
+77
| self.assertEqual(project.country, "US") | ||
| self.assertEqual(project.type, "biomass") | ||
| self.assertEqual(project.developer, "Patch Sandbox Supplier Test") | ||
| self.assertIsInstance(project.country, str) | ||
| self.assertIsInstance(project.type, str) | ||
| self.assertIsInstance(project.developer, str) |
Contributor
Author
There was a problem hiding this comment.
Those were too brittle and failing. Proposing to keep tests dumb in the SDKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
** CHANGEME: Why are these changes needed? **
SDK Release Checklist