Add automatic initial timestep selection to Simulation#227
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automatic initial timestep selection following Hairer-Norsett-Wanner.
Simulation.estimate_initial_step()forms a first guess from the scaled norms of the state and its derivative, then refines it with a second-derivative estimate from an explicit Euler probe (a pure evaluation, no actual timestep / no events). Scaling uses the engine error tolerances.Block.derivative(t)accessor: the base implementation covers blocks with a dynamic operator (ODE,DynamicalSystem,LTI, and the DAE blocks via their reduced operator);Integratoroverrides it; stateless blocks returnNoneand are skipped.dt=Noneto the simulation triggers the estimate at the start of the run; otherwise behaviour is unchanged.Tests cover the derivative accessor, step scaling with the dynamics, state restoration, and an end-to-end auto-dt run.