Skip to content

fix(Grid): Provide Row, Col, Clearfix as children of Grid - #161

Merged
priley86 merged 2 commits into
patternfly:masterfrom
jeff-phillips-18:grid
Jan 11, 2018
Merged

fix(Grid): Provide Row, Col, Clearfix as children of Grid#161
priley86 merged 2 commits into
patternfly:masterfrom
jeff-phillips-18:grid

Conversation

@jeff-phillips-18

@jeff-phillips-18 jeff-phillips-18 commented Jan 11, 2018

Copy link
Copy Markdown
Member

What:
Add Row, Col, and Clearfix as children of Grid. Now one just needs to import Grid and use Grid.Row, Grid.Col, and/or Grid.Clearfix

No visual or functional changes here.

@jeff-phillips-18

jeff-phillips-18 commented Jan 11, 2018

Copy link
Copy Markdown
Member Author

Added as a 'fix', maybe it should be a 'feature' so folks can specify the release more easily when starting to use these. Thoughts?

@ohadlevy

ohadlevy commented Jan 11, 2018

Copy link
Copy Markdown
Member

will this break anyone existing usage? /cc @sharvit @danseethaler

@jeff-phillips-18

jeff-phillips-18 commented Jan 11, 2018

Copy link
Copy Markdown
Member Author

It shouldn't break anything. Grid, Col, and Clearfix are still exported. This is just for convenience.

@sharvit

sharvit commented Jan 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @jeff-phillips-18 .
Can you also update the Grid storybook? so consumers will know this feature is exists.

@jeff-phillips-18

jeff-phillips-18 commented Jan 11, 2018

Copy link
Copy Markdown
Member Author

@sharvit I have updated the storybook. However, the documentation does not change when using the subcomponents.

@sharvit

sharvit commented Jan 11, 2018

Copy link
Copy Markdown
Contributor

I know @jeff-phillips-18, saw it happen before unfortunately.
But i saw many developers here opening github and reading the storybook code itself so at least it will give them a value.

sharvit
sharvit approved these changes Jan 11, 2018
View reviewed changes

@sharvit sharvit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cdcabrera
cdcabrera approved these changes Jan 11, 2018
View reviewed changes

@cdcabrera cdcabrera left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priley86

priley86 commented Jan 11, 2018

Copy link
Copy Markdown
Member

apologies... Github was down for a bit and I only saw a very angry unicorn. 🦄 merging this now...

@priley86
priley86 merged commit 80eb953 into patternfly:master Jan 11, 2018
@jgiardino jgiardino removed the review label Jan 11, 2018
@jeff-phillips-18
jeff-phillips-18 deleted the grid branch March 13, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdcabrera cdcabrera cdcabrera approved these changes
+2 more reviewers
@sharvit sharvit sharvit approved these changes
@priley86 priley86 priley86 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jeff-phillips-18 @ohadlevy @sharvit @priley86 @cdcabrera @jgiardino