Skip to content

Use ignore-id instead of deprecated ignore in Composer - #20368

Open
liviuconcioiu wants to merge 1 commit into
phpmyadmin:QA_5_2from
liviuconcioiu:composer
Open

Use ignore-id instead of deprecated ignore in Composer#20368
liviuconcioiu wants to merge 1 commit into
phpmyadmin:QA_5_2from
liviuconcioiu:composer

Conversation

@liviuconcioiu

Copy link
Copy Markdown
Contributor

Description

ignore is deprecated - https://getcomposer.org/doc/06-config.md#ignore-3
ingore-id should be used instead - https://getcomposer.org/doc/06-config.md#ignore-id

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

@williamdes williamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am unsure of the version coverage of both syntaxes

@MauricioFauth

Copy link
Copy Markdown
Member

LGTM, but I am unsure of the version coverage of both syntaxes

This only works for Composer 2.10+. I'm not sure if this should be merged to QA_5_2. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants