remove auto escape from page title to avoid & bug - #20402
Open
rlittle316 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Robert Little <robert.little@appian.com>
Author
|
Im not sure if this should be patched in the current version of phpmyadmin or not. A workaround I have found for this issue is to pre replace any & with the full width version of it which bypasses the auto escaping done by twig. |
Contributor
|
This should be fixed in 5.2, but instead of taking the raw value in Twig, I would just remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to disable twig auto escaping on header.title. When & is used in the title with this enabled it is rendered as
&in the title.Fixes #
This fixes the incorrect title rendered when a & is passed to the title.
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.