Add support for PHPUnit 10, 11, 12 and 13 by MauricioFauth · Pull Request #20405 · phpmyadmin/phpmyadmin

MauricioFauth · 2026-07-29T06:27:59Z

https://bugs.debian.org/1139522

codecov · 2026-07-29T14:17:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.27%. Comparing base (393d71b) to head (8ae96b8).
⚠️ Report is 10 commits behind head on QA_5_2.

Additional details and impacted files

@@             Coverage Diff              @@
##             QA_5_2   #20405      +/-   ##
============================================
+ Coverage     48.15%   48.27%   +0.11%     
  Complexity    17244    17244              
============================================
  Files           607      607              
  Lines         72679    72678       -1     
============================================
+ Hits          34999    35085      +86     
+ Misses        37680    37593      -87

Flag	Coverage Δ
dbase-extension	`49.09% <ø> (?)`
recode-extension	`49.03% <ø> (-0.05%)`	⬇️
unit-7.2-ubuntu-latest	`49.00% <ø> (?)`
unit-7.4-ubuntu-latest	`?`
unit-8.0-ubuntu-latest	`49.48% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

williamdes

Thank you so much for this PR !
Beware we have https://salsa.debian.org/php-team/pear/rector-poc to do auto migration. that said there is work to do because it strips phpdoc annotations. But if you can workaround that it will help. Or maybe next time

MauricioFauth · 2026-07-30T13:42:13Z

Thank you so much for this PR ! Beware we have https://salsa.debian.org/php-team/pear/rector-poc to do auto migration. that said there is work to do because it strips phpdoc annotations. But if you can workaround that it will help. Or maybe next time

I'm using Rector as well, but it doesn't fix everything and it doesn't get it right all the time.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Psalm needs to be removed to install PHPUnit >= 10. Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

liviuconcioiu · 2026-07-31T06:10:32Z

@MauricioFauth nice work! Just a few errors, if compiled locales are missing. Probably those tests should be skiped.

E:\GitHub\phpmyadmin>composer run phpunit
> @php phpunit --color=always
PHPUnit 13.2.6 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.5.9
Configuration: E:\GitHub\phpmyadmin\phpunit.xml.dist
Random Seed:   1785477832

.............................................................   61 / 3183 (  1%)
.............................................................  122 / 3183 (  3%)
...................................D..................D..D...  183 / 3183 (  5%)
.............................................................  244 / 3183 (  7%)
.............................................................  305 / 3183 (  9%)
.............................................................  366 / 3183 ( 11%)
.............................................................  427 / 3183 ( 13%)
.............................................................  488 / 3183 ( 15%)
...........................................................D.  549 / 3183 ( 17%)
.............................................................  610 / 3183 ( 19%)
.............................................................  671 / 3183 ( 21%)
.............................................................  732 / 3183 ( 22%)
.............................................................  793 / 3183 ( 24%)
.............................................................  854 / 3183 ( 26%)
.........................................................D...  915 / 3183 ( 28%)
.............................................................  976 / 3183 ( 30%)
..........................................................D.. 1037 / 3183 ( 32%)
............................................................. 1098 / 3183 ( 34%)
............................................................. 1159 / 3183 ( 36%)
.............................D............................... 1220 / 3183 ( 38%)
................SS.S.SSS..................................... 1281 / 3183 ( 40%)
............................................................. 1342 / 3183 ( 42%)
......................DDDDDDDD............................... 1403 / 3183 ( 44%)
............................................................. 1464 / 3183 ( 45%)
............................................................. 1525 / 3183 ( 47%)
............................................................. 1586 / 3183 ( 49%)
............................................................. 1647 / 3183 ( 51%)
............................................................. 1708 / 3183 ( 53%)
........................DDD.....D....D....................... 1769 / 3183 ( 55%)
............................................................. 1830 / 3183 ( 57%)
............................................................. 1891 / 3183 ( 59%)
............................................................. 1952 / 3183 ( 61%)
............................................................. 2013 / 3183 ( 63%)
............................................................. 2074 / 3183 ( 65%)
............................................................. 2135 / 3183 ( 67%)
............................................................. 2196 / 3183 ( 68%)
............................................................. 2257 / 3183 ( 70%)
............................................................. 2318 / 3183 ( 72%)
.......................D.D...D............................... 2379 / 3183 ( 74%)
..................................SESESESESESESESESESESESESES 2440 / 3183 ( 76%)
ESESESESESESESESESESESESESESESESE..DDDDDDDDDDDDDDDDD......... 2501 / 3183 ( 78%)
............................................................. 2562 / 3183 ( 80%)
.....................................................S.S..... 2623 / 3183 ( 82%)
......S................................................S..... 2684 / 3183 ( 84%)
....S........................................................ 2745 / 3183 ( 86%)
............S.................D.D...DD.D.D...D.D.DD.D.DDD.... 2806 / 3183 ( 88%)
...DD.DD..................................................... 2867 / 3183 ( 90%)
............................................................. 2928 / 3183 ( 91%)
............................................................. 2989 / 3183 ( 93%)
............................................................. 3050 / 3183 ( 95%)
............................................................. 3111 / 3183 ( 97%)
............................................................. 3172 / 3183 ( 99%)
...........                                                   3183 / 3183 (100%)..............................

Time: 01:17.222, Memory: 118.00 MB

There were 30 errors:

1) PhpMyAdmin\Tests\LanguageTest::testAllAvailable
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

2) PhpMyAdmin\Tests\LanguageTest::testGettext#0 with data ('en')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

3) PhpMyAdmin\Tests\LanguageTest::testSortedLanguages
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

4) PhpMyAdmin\Tests\LanguageTest::testGet
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

5) PhpMyAdmin\Tests\LanguageTest::testLanguages
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

6) PhpMyAdmin\Tests\LanguageTest::testMySQLLocale
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

7) PhpMyAdmin\Tests\LanguageTest::testList
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

8) PhpMyAdmin\Tests\LanguageTest::testSelect#7 with data ('', '', '', '', '', '', 'cs', 'cs')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

9) PhpMyAdmin\Tests\LanguageTest::testSelect#2 with data ('', 'cs', 'en', '', '', '', '', 'cs')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

10) PhpMyAdmin\Tests\LanguageTest::testSelect#3 with data ('', '', 'cs', '', '', '', '', 'cs')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

11) PhpMyAdmin\Tests\LanguageTest::testSelect#1 with data ('', 'cs', '', '', '', '', '', 'cs')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

12) PhpMyAdmin\Tests\LanguageTest::testSelect#13 with data ('', '', '', '', 'ar-AE,ar;q=0.8,en-US;q=0.5,en;q=0.3', '', 'en', 'ar')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

13) PhpMyAdmin\Tests\LanguageTest::testSelect#16 with data ('', '', '', '', 'en-GB,en;q=0.7,pt;q=0.3', '', 'pt', 'en_GB')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

14) PhpMyAdmin\Tests\LanguageTest::testSelect#20 with data ('', '', '', '', 'zh-HK,zh;q=0.7,en;q=0.3', '', 'en', 'zh_TW')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

15) PhpMyAdmin\Tests\LanguageTest::testSelect#11 with data ('', '', '', '', 'pt-BR,pt;q=0.8,en-US;q=0.5,en;q=0.3', '', 'en', 'pt_BR')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

16) PhpMyAdmin\Tests\LanguageTest::testSelect#10 with data ('', '', '', '', 'pt-PT,pt;q=0.8,en-US;q=0.5,en;q=0.3', '', 'en', 'pt')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

17) PhpMyAdmin\Tests\LanguageTest::testSelect#19 with data ('', '', '', '', 'zh-CN,zh;q=0.7,en;q=0.3', '', 'en', 'zh_CN')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

18) PhpMyAdmin\Tests\LanguageTest::testSelect#18 with data ('', '', '', '', 'zh,en;q=0.5', '', 'en', 'zh_CN')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

19) PhpMyAdmin\Tests\LanguageTest::testSelect#9 with data ('', '', '', '', 'pt;q=0.8,en-US;q=0.5,en;q=0.3', '', 'en', 'pt')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

20) PhpMyAdmin\Tests\LanguageTest::testSelect#8 with data ('', '', '', '', '', '', '', 'en')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

21) PhpMyAdmin\Tests\LanguageTest::testSelect#17 with data ('', '', '', '', 'en-US,en;q=0.7,pt;q=0.3', '', 'pt', 'en')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

22) PhpMyAdmin\Tests\LanguageTest::testSelect#6 with data ('', '', '', '', '', 'Mozilla/5.0 (Linux; U; Androi...M FOX)', '', 'tr')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

23) PhpMyAdmin\Tests\LanguageTest::testSelect#5 with data ('', '', '', '', 'cs,en-US;q=0.7,en;q=0.3', '', '', 'cs')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

24) PhpMyAdmin\Tests\LanguageTest::testSelect#15 with data ('', '', '', '', 'en,pt;q=0.5', '', 'pt', 'en')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

25) PhpMyAdmin\Tests\LanguageTest::testSelect#4 with data ('', '', '', 'cs', '', '', '', 'cs')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

26) PhpMyAdmin\Tests\LanguageTest::testSelect#14 with data ('', '', '', '', 'ar-LY,ar;q=0.8,en-US;q=0.5,en;q=0.3', '', 'en', 'ar_LY')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

27) PhpMyAdmin\Tests\LanguageTest::testSelect#0 with data ('cs', 'en', '', '', '', '', '', 'cs')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

28) PhpMyAdmin\Tests\LanguageTest::testSelect#12 with data ('', '', '', '', 'ar;q=0.8,en-US;q=0.5,en;q=0.3', '', 'en', 'ar')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

29) PhpMyAdmin\Tests\LanguageTest::testSelect#21 with data ('', '', '', '', 'zh-TW,zh;q=0.7,en;q=0.3', '', 'en', 'zh_TW')
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

30) PhpMyAdmin\Tests\LanguageTest::testAvailable
Error: Call to a member function getLanguage() on null

E:\GitHub\phpmyadmin\test\classes\LanguageTest.php:50
E:\GitHub\phpmyadmin\vendor\phpunit\phpunit\phpunit:104
E:\GitHub\phpmyadmin\vendor\bin\phpunit:122

ERRORS!
Tests: 3213, Assertions: 12791, Errors: 30, PHPUnit Deprecations: 59, Skipped: 42.
Script @php phpunit --color=always handling the phpunit event returned with error code 2

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

MauricioFauth force-pushed the phpunit-13-support branch from 3215f73 to 7fe41ef Compare July 29, 2026 06:32

MauricioFauth force-pushed the phpunit-13-support branch 2 times, most recently from a03155b to 48e6114 Compare July 29, 2026 16:41

MauricioFauth added 2 commits July 29, 2026 18:18

Fix PHPUnit 9 deprecations

1281b7c

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Fix arg count mismatch in test data providers

762fdbf

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

MauricioFauth force-pushed the phpunit-13-support branch 3 times, most recently from 32ad9f3 to 79cb929 Compare July 30, 2026 03:05

williamdes approved these changes Jul 30, 2026

View reviewed changes

MauricioFauth force-pushed the phpunit-13-support branch from 3bd6fd5 to 6559823 Compare July 30, 2026 17:59

MauricioFauth added 4 commits July 30, 2026 17:57

Fix multiple expectation on output in CoreTest

fe8a56f

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Add PHPUnit 10, 11, 12 and 13 builds to CI

8b8b880

Psalm needs to be removed to install PHPUnit >= 10. Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Fix PHPUnit 10 failing tests and deprecations

80b1bb3

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Add PHPUnit attributes

4742c1f

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

MauricioFauth force-pushed the phpunit-13-support branch from 59790f4 to abc60a8 Compare July 30, 2026 21:39

MauricioFauth marked this pull request as ready for review July 30, 2026 21:44

MauricioFauth self-assigned this Jul 30, 2026

williamdes approved these changes Jul 31, 2026

View reviewed changes

MauricioFauth added 9 commits July 31, 2026 13:31

Move large and medium annotations to the class instead of methods

56fadd9

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Use assertMatchesRegularExpressionCompat where possible

0613511

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Fix PHPUnit 11 deprecations

3e61699

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Fix PHPUnit 12 deprecations

fbb6bfd

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Add AllowMockObjectsWithoutExpectations PHPUnit attribute

4974299

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Remove deprecated constant E_STRICT

0b27759

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Fix coding standard issues

86fb10e

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Update PHPStan and Psalm baselines

f5ce014

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

Fix LanguageTest failing test when missing locales

8ccc5b6

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>

MauricioFauth force-pushed the phpunit-13-support branch from abc60a8 to 8ccc5b6 Compare July 31, 2026 16:34

MauricioFauth added this to the 5.2.4 milestone Jul 31, 2026

MauricioFauth merged commit 0ac0af5 into phpmyadmin:QA_5_2 Jul 31, 2026
58 checks passed

MauricioFauth deleted the phpunit-13-support branch July 31, 2026 16:55

liviuconcioiu mentioned this pull request Jul 31, 2026

[5.2]: PHPUnit 13 deprecations #20364

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add support for PHPUnit 10, 11, 12 and 13 - #20405

Add support for PHPUnit 10, 11, 12 and 13#20405
MauricioFauth merged 15 commits into
phpmyadmin:QA_5_2from
MauricioFauth:phpunit-13-support

MauricioFauth commented Jul 29, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 29, 2026

Uh oh!

williamdes left a comment

Uh oh!

MauricioFauth commented Jul 30, 2026

Uh oh!

liviuconcioiu commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

MauricioFauth commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 29, 2026

Codecov Report

Uh oh!

williamdes left a comment

Choose a reason for hiding this comment

Uh oh!

MauricioFauth commented Jul 30, 2026

Uh oh!

liviuconcioiu commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MauricioFauth commented Jul 29, 2026 •

edited

Loading