fix(mobile): extend blockquotes across wrapped lines - #6482
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0ed0611. Configure here.
ApprovabilityVerdict: Needs human review 1 blocking correctness issue found. You can customize Macroscope's approvability policy. Learn more. |
773758e to
d0a24be
Compare
There was a problem hiding this comment.
reviewed the exact d0a24be head. the rich blockquote path now fixes wrapped markers while preserving skill decoration through nested rich renderers. regression tests, ci, and the before/after simulator evidence all look good.
## What's Changed * fix(mobile): extend blockquotes across wrapped lines by @chrisdeeming in pingdotgg/t3code#6482 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260813.1086...v0.0.34-nightly.20260813.1087 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260813.1087

What Changed
Why
The iOS React Native selectable Markdown path represented a blockquote with a literal
│text glyph. That marker only appeared on the first rendered line when a single Markdown line wrapped, even though the provider output was correct. Rendering the blockquote as a bordered container makes the marker follow the measured height of its content.UI Changes
Before
After
Checklist
Created with gpt-5.6-sol using the Codex harness in T3 Code.
Note
Low Risk
Mobile-only markdown presentation and prop threading; no auth, data, or API changes.
Overview
Plain blockquotes on iOS now use the rich markdown path (
containsRichBlockincludesblockquote) so they render viaNativeMarkdownBlock’s left border instead of a│character in selectable text—fixing markers that disappeared after the first wrapped line.skillsis threaded throughNativeMarkdownBlockand nested renderers, and selectable/table text usesnativeMarkdownDocumentRuns(with skills) instead ofnativeMarkdownTextRuns, so$skilldecoration still works inside blockquotes and table cells. Regression tests cover rich blockquote chunking and skills in quotes.Reviewed by Cursor Bugbot for commit d0a24be. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix blockquote rendering to extend across wrapped lines on mobile
node.type === "blockquote"tocontainsRichBlockin nativeMarkdownText.ts, routing blockquotes through the rich rendering path so they render correctly across line wraps.skillsarray throughNativeMarkdownBlockand all child components (SelectableNode,NativeTable,NativeMarkdownImage,NativeMixedParagraph,NativeList) so skill-link decoration applies inside rich blocks including blockquotes.nativeMarkdownTextRunswithnativeMarkdownDocumentRunsin table cells and selectable nodes to support skill decoration.NativeMarkdownBlocknow requires askillsprop; callers must pass it.Macroscope summarized d0a24be.