Skip to content

fix(mobile): extend blockquotes across wrapped lines - #6482

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
chrisdeeming:fix/mobile-markdown-blockquote-wrap
Aug 13, 2026
Merged

fix(mobile): extend blockquotes across wrapped lines#6482
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
chrisdeeming:fix/mobile-markdown-blockquote-wrap

Conversation

@chrisdeeming

@chrisdeeming chrisdeeming commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Route React Native blockquotes through the existing bordered block renderer so the quote marker spans every visually wrapped line in both user and assistant messages.
  • Add regression coverage that keeps plain blockquotes in rich Markdown chunks.
  • Verify the change with the focused Markdown tests, mobile typecheck, targeted lint, and an iOS Simulator pass.

Why

The iOS React Native selectable Markdown path represented a blockquote with a literal text glyph. That marker only appeared on the first rendered line when a single Markdown line wrapped, even though the provider output was correct. Rendering the blockquote as a bordered container makes the marker follow the measured height of its content.

UI Changes

Before

Before: blockquote markers stop after the first rendered line

After

After: blockquote borders span all wrapped lines

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • A video is not applicable because this change has no animation or interaction

Created with gpt-5.6-sol using the Codex harness in T3 Code.


Note

Low Risk
Mobile-only markdown presentation and prop threading; no auth, data, or API changes.

Overview
Plain blockquotes on iOS now use the rich markdown path (containsRichBlock includes blockquote) so they render via NativeMarkdownBlock’s left border instead of a character in selectable text—fixing markers that disappeared after the first wrapped line.

skills is threaded through NativeMarkdownBlock and nested renderers, and selectable/table text uses nativeMarkdownDocumentRuns (with skills) instead of nativeMarkdownTextRuns, so $skill decoration still works inside blockquotes and table cells. Regression tests cover rich blockquote chunking and skills in quotes.

Reviewed by Cursor Bugbot for commit d0a24be. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix blockquote rendering to extend across wrapped lines on mobile

  • Adds node.type === "blockquote" to containsRichBlock in nativeMarkdownText.ts, routing blockquotes through the rich rendering path so they render correctly across line wraps.
  • Propagates a skills array through NativeMarkdownBlock and all child components (SelectableNode, NativeTable, NativeMarkdownImage, NativeMixedParagraph, NativeList) so skill-link decoration applies inside rich blocks including blockquotes.
  • Replaces nativeMarkdownTextRuns with nativeMarkdownDocumentRuns in table cells and selectable nodes to support skill decoration.
  • Behavioral Change: NativeMarkdownBlock now requires a skills prop; callers must pass it.

Macroscope summarized d0a24be.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 57a30b70-52d0-4712-b3d7-8d5e6e07f728

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 13, 2026
Comment thread apps/mobile/modules/t3-markdown-text/src/nativeMarkdownText.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0ed0611. Configure here.

Comment thread apps/mobile/modules/t3-markdown-text/src/nativeMarkdownText.ts
@macroscopeapp

macroscopeapp Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

1 blocking correctness issue found.

You can customize Macroscope's approvability policy. Learn more.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 13, 2026
@chrisdeeming
chrisdeeming force-pushed the fix/mobile-markdown-blockquote-wrap branch from 773758e to d0a24be Compare August 13, 2026 15:50

@t3-code t3-code Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the exact d0a24be head. the rich blockquote path now fixes wrapped markers while preserving skill decoration through nested rich renderers. regression tests, ci, and the before/after simulator evidence all look good.

@juliusmarminge
juliusmarminge merged commit fd51561 into pingdotgg:main Aug 13, 2026
17 checks passed
@chrisdeeming
chrisdeeming deleted the fix/mobile-markdown-blockquote-wrap branch August 13, 2026 18:09
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants