Skip to content

don't leak GIT_* env into npm install for language: node #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asottile merged 1 commit into from
Oct 12, 2026
Merged

don't leak GIT_* env into npm install for language: node #3774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pre_commit/languages/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from pre_commit.envcontext import PatchesT
from pre_commit.envcontext import UNSET
from pre_commit.envcontext import Var
from pre_commit.git import no_git_env
from pre_commit.languages.python import bin_dir
from pre_commit.prefix import Prefix
from pre_commit.util import cmd_output
Expand Down Expand Up @@ -103,4 +104,4 @@ def install_environment(
'npm', 'install', '--allow-git=root', '--install-links', '-g',
*pkgs,
)
lang_base.setup_cmd(prefix, install)
lang_base.setup_cmd(prefix, install, env=no_git_env())
23 changes: 23 additions & 0 deletions tests/languages/node_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,29 @@ def test_node_hook_system(tmp_path):
assert ret == (0, b'Hello World\n')


def test_node_hook_install_does_not_write_callers_index(tmp_path):
# git sets GIT_DIR / GIT_INDEX_FILE to absolute paths when running hooks
# in a submodule, `npm install git+file://...` must not inherit them
hook_repo = tmp_path.joinpath('hook')
hook_repo.mkdir()
_make_hello_world(hook_repo)

user_repo = tmp_path.joinpath('user')
cmd_output_b('git', 'init', user_repo)
user_repo.joinpath('f').touch()
cmd_output_b('git', 'add', 'f', cwd=user_repo)

git_dir = user_repo.joinpath('.git')
with envcontext.envcontext((
('GIT_DIR', str(git_dir)),
('GIT_INDEX_FILE', str(git_dir.joinpath('index'))),
)):
ret = run_language(hook_repo, node, 'node-hello')
assert ret == (0, b'Hello World\n')

assert cmd_output('git', 'ls-files', cwd=user_repo)[1] == 'f\n'


def test_node_with_user_config_set(tmp_path):
cfg = tmp_path.joinpath('cfg')
cfg.write_text('cache=/dne\n')
Expand Down
Loading