Skip to content

#576 add SafepointExports#577

Open
mr-git wants to merge 3 commits intoprometheus:mainfrom
mr-git:576
Open

#576 add SafepointExports#577
mr-git wants to merge 3 commits intoprometheus:mainfrom
mr-git:576

Conversation

@mr-git
Copy link

@mr-git mr-git commented Oct 11, 2020 •
edited
Loading

seems that the management API has been around since at least JDK 6 (http://srcrr.com/java/oracle/openjdk/6/reference/sun/management/HotspotRuntimeMBean-source.html)

@mr-git
prometheus#576 add SafepointExports
1c4b564 
Signed-off-by: mr-git <8796159+mr-git@users.noreply.github.com>
@mr-git mr-git marked this pull request as ready for review October 11, 2020 18:44
@mr-git
Copy link
Author

mr-git commented Oct 11, 2020

@brian-brazil, please review - my local mvn is broken, but I checked the management API - it works at least on OpenJDK 14 and GraalVM 20.0.0 (java 1.8.0_242)

brian-brazil
brian-brazil reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@brian-brazil brian-brazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it on the IBM JVM? It's not the hotspot ones I'm worried about.

@mr-git
prometheus#576 add SafepointExports (Counters should end in _total)
f05e847 
Signed-off-by: mr-git <8796159+mr-git@users.noreply.github.com>
@mr-git
Copy link
Author

mr-git commented Oct 20, 2020 •
edited
Loading

Have you tested it on the IBM JVM? It's not the hotspot ones I'm worried about.

No, I haven't :(
Which IBM JVM would you recommend to try?

I found some links, that IBM is contributing to J9 and there is hotspot runtime mbean in place:
https://github.com/search?q=org%3AAdoptOpenJDK+getHotspotRuntimeMBean&type=code

@mr-git
prometheus#576 add SafepointExports (Merge two Counters in Summary)
ebcc395 
Signed-off-by: mr-git <8796159+mr-git@users.noreply.github.com>
@brian-brazil
Copy link
Contributor

brian-brazil commented Oct 20, 2020

Which IBM JVM would you recommend to try?

Whatever is easiest to get your hands on.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

This PR has been marked as stale due to 120 days of inactivity. It will be automatically closed if there is no further activity over the next 30 days.

@github-actions github-actions bot added the stale label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@brian-brazil brian-brazil brian-brazil left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mr-git @brian-brazil