added _max to summary allowed_names#264
Closed
afriemann wants to merge 1 commit into
Closed
Conversation
Contributor
|
_max is not a suffix that a summary can produce. It's micrometer you need to take this up with, as it's them that are producing bad output. Those maxes would need to be a separate gauge. |
Author
|
Alright, as expected. No problems and thanks a lot anyway! |
|
For anybody that finds this later... this was fixed in micrometer-metrics/micrometer#519 and scheduled for inclusion in Micrometer 1.0.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brian-brazil
We have a few teams using the micrometer metrics library and it comes with a "Timer" metric (which is actually a summary). Unfortunately that metric seems to produce "_max" metrics in addition to "_sum" and "_count".
This results in the parser producing invalid Output:
While I don't see this anywhere in the Prometheus documentation and absolutely understand if it is being rejected, I hope this is sensible enough to make it upstream.