Make it possible to specify a directory path#354
Closed
slater-brian-john wants to merge 3 commits into
Closed
Conversation
fd27a24 to
58e91e5
Compare
Contributor
|
I'm not seeing how this changes how the code works. |
Signed-off-by: Brian Slater <brian.slater@spothero.com>
58e91e5 to
8d0c87c
Compare
Author
Sorry about that. I did not change anything, this should do what I would like now :) |
Signed-off-by: Brian Slater <brian.slater@spothero.com>
6e147bc to
1ede26f
Compare
Signed-off-by: Brian Slater <brian.slater@spothero.com>
992dcba to
35c1a15
Compare
Contributor
|
That's still doing the same thing. |
Author
|
Previously, if you passed a path into the application you would get a ValueError, that is, I could not use the path argument. |
Contributor
|
The logic is still the same, so if you got an exception before you'd get one now. |
Author
|
No idea what I was thinking, sorry to waste your time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed whilst trying to use MultiprocessCollector that I could not set a the path variable.