Provide a way of checking if the catalogs are up-to-date - #831
Merged
Conversation
kjagiello
commented
Jan 26, 2022
kjagiello
commented
Jan 26, 2022
akx
self-requested a review
January 26, 2022 19:04
akx
requested changes
Jan 28, 2022
akx
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution, seems like a good addition. Some comments around naming and so on...
Contributor
Author
|
@akx Let me know if there is anything else that needs to be taken care of before we can merge this PR |
akx
self-requested a review
February 20, 2022 14:57
akx
requested changes
Apr 8, 2022
akx
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay! Could you rebase this?
Contributor
Author
|
Sure thing, done! |
Member
|
@kjagiello Tests are unhappy 😭 |
Contributor
Author
|
This will hopefully do the trick! Forgot to do init. |
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 91.09% 91.12% +0.02%
==========================================
Files 23 23
Lines 4156 4190 +34
==========================================
+ Hits 3786 3818 +32
- Misses 370 372 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was missing a way to, as a part of CI-pipeline, check if the translations files are up to date. This PRs attempts to implement it in form of a
--checkflag forpybabel update.