Build debug libraries when CMAKE_BUILD_TYPE is set to Debug#151
Closed
dbrnz wants to merge 4 commits intopython-cmake-buildsystem:masterfrom
Closed
Build debug libraries when CMAKE_BUILD_TYPE is set to Debug#151dbrnz wants to merge 4 commits intopython-cmake-buildsystem:masterfrom
dbrnz wants to merge 4 commits intopython-cmake-buildsystem:masterfrom
Conversation
Contributor
|
Thanks for the patch 👍 I will review and integrate later this week. |
CMakeLists.txt
Outdated
| cmake_minimum_required(VERSION 3.3) # Version introducing CROSSCOMPILING_EMULATOR | ||
| endif() | ||
|
|
||
| if(WIN32 AND "${CMAKE_BUILD_TYPE}" STREQUAL "Debug") |
Contributor
There was a problem hiding this comment.
The CMAKE_DEBUG_POSTFIX variable only preseeds the Debug build type suffix, so there is no need to add that to the condition.
https://cmake.org/cmake/help/v2.8.5/cmake.html#variable:CMAKE_DEBUG_POSTFIX
Contributor
Author
There was a problem hiding this comment.
Thanks @adrianbroher, the redundant check on CMAKE_BUILD_TYPE has been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address issue #12.