Conversation
This reverts commit 6d63f33e978f05feba74e03e21726674c3ffc927.
fregante
commented
Jul 2, 2022
| select('#js-repo-pjax-container, #js-pjax-container')?.append(<has-rgh/>); | ||
| select('#repo-content-pjax-container, turbo-frame')?.append(<has-rgh-inner/>); // #4567 | ||
| select(_`#js-repo-pjax-container, #js-pjax-container`)?.append(<has-rgh/>); | ||
| select(_`#repo-content-pjax-container, turbo-frame`)?.append(<has-rgh-inner/>); // #4567 |
Member
Author
There was a problem hiding this comment.
This is likely to change soon, so it's the first target for dynamic replacement
| getLocalStrings(), | ||
| ]); | ||
|
|
||
| console.log({value: _`Original`}); |
Member
Author
There was a problem hiding this comment.
Line 98 and line 108 show the regular string and then the string after the replacement
thanks to
https://github.com/refined-github/yolo/blob/0edd58aed757c51062a235715c8a0d7037731da0/strings.json#L2
fregante
commented
Jul 2, 2022
| return ''; | ||
| } | ||
|
|
||
| export type HotfixStorage = Array<[FeatureID, string]>; |
Member
Author
There was a problem hiding this comment.
I think eventually we should have a single updater function and a single hotfixes object in the options, like:
{
style: 'body {color: red}',
broken: ['forked-to'],
strings: {from: 'to'},
}
fregante
commented
Jul 2, 2022
|
|
||
| const storage: HotfixStorage = []; | ||
| for (const [featureID, unaffectedVersion, relatedIssue] of parseCsv(atob(content))) { | ||
| for (const [featureID, relatedIssue, unaffectedVersion] of parseCsv(content)) { |
Member
Author
There was a problem hiding this comment.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JessiG2319
approved these changes
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refined-github/refined-github#1234instead of just#1234(or just the whole issue URL)