Skip to content

Make ArrayViewMut::into_view public to allow lifetime preservation during conversion #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akern40 merged 2 commits into from
Jun 19, 2026
+61 −2
Merged

Make ArrayViewMut::into_view public to allow lifetime preservation during conversion #1600

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c615f45
Make ArrayViewMut::into_view public and implement From conversion (#1…
at264939-ctrl Jun 19, 2026
da0b686
Fix docs link and format for CI
at264939-ctrl Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix docs link and format for CI
  • Loading branch information
@at264939-ctrl
at264939-ctrl committed Jun 19, 2026
commit da0b686cfb28323a7250d22df4387c8c03abc104
4 changes: 2 additions & 2 deletions src/impl_views/conversions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ where D: Dimension
{
/// Convert into a read-only view.
///
/// Unlike [`Self::view`], this method consumes the mutable view and preserves
/// the original lifetime of the data.
/// This method consumes the mutable view and returns an `ArrayView` that
/// preserves the original lifetime `'a` of the data.
pub fn into_view(self) -> ArrayView<'a, A, D>
{
unsafe { ArrayView::new(self.parts.ptr, self.parts.dim, self.parts.strides) }
Expand Down
12 changes: 8 additions & 4 deletions tests/views.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,20 @@ fn test_view_conversion()
fn test_view_conversion_lifetime()
{
// Regression test for #1595
struct Foo<'a> {
struct Foo<'a>
{
data: ArrayViewMut2<'a, f32>,
}

impl<'a> Foo<'a> {
fn into_shared(self) -> ArrayView2<'a, f32> {
impl<'a> Foo<'a>
{
fn into_shared(self) -> ArrayView2<'a, f32>
{
self.data.into_view()
}

fn into_shared_from(self) -> ArrayView2<'a, f32> {
fn into_shared_from(self) -> ArrayView2<'a, f32>
{
self.data.into()
}
}
Expand Down
Loading