refactoring, small fix, improved whitespacehandling#2
Merged
Conversation
added 9 commits
November 26, 2013 14:33
…sarbian-master Conflicts: moduleManager.cs
Contributor
Author
|
The % operator worked in all my tests, I changed ! to remove all instances of a given valName, not sure if that is acceptable behavior, before it just removed the one instance. |
sarbian
added a commit
that referenced
this pull request
Nov 27, 2013
refactoring, small fix, improved whitespacehandling, % on value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this re-factors mostly the CheckConditions function and removes the Trim() invocations with a function that removes all white-space out of a given string. Initially I thought this could fix the issue that came up in the KSPforum thread, but as mentioned there, KSP seems to truncate those lines at the first whitespace.
Also: Fixed the issue that MM.dll won an election against itself. :)
And: Moves the Assembly.cs to the place where it should usually be.
As far as I could test this works as it is supposed to. But it might be good to get some additional testing.
Have you thought about re-licencing the source under a proper opensource Licence? GPLv3 seems to be fairly common for KSP-Mods. I guess it would be necessary to contact Ialdabaoth about that.. the original author is mentioned in the GPL as well.
The issue is that Creative Commons should not be used for software:
http://wiki.creativecommons.org/FAQ#Can_I_use_a_Creative_Commons_license_for_software.3F
I am not really sure what the problems are with CC and software, but I thought I mention it at least. :)