Adjusting make install#684
Merged
Merged
Conversation
Author
|
I don't understand if the error in the CI publishing the code coverage is related to my change: [2024-10-11T16:49:08.866Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 1612s."} |
Member
|
@taconi I've updated the codecov token. It should work now 🤞 |
Author
|
lock updated in #685, but the pre-commit install command fails because it only exists inside venv |
camilamaia
approved these changes
Oct 14, 2024
Member
camilamaia
left a comment
There was a problem hiding this comment.
Nice!! Thanks! I'll fix the Codecov so it doesn't need a token since the repo is public. I think it's trying to get the token from the fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusting
make installMotivation behind this PR?
releated #683
What type of change is this?
Bug Fix
Checklist
Issue
Closes #683