Allow for using define hat shape as a modifier - #462
Open
duckboycool wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mentioned in #449
This pull request adds
define-hatto the list of override shapes, and modifiesdraw()to render the blocks without clipping on the top (happens otherwise if you don't have a block inside the define hat) and to show the 2.0 define hat cap with different colors from the custom purple.Currently, this lacks the ability to make outline blocks like in the normal define block.
It also needs a rework to how the fill color on the cap for 2.0 works. It is currently the same color as the stroke for a category modifier, which might require manually choosing new colors for each category except custom. For rgb color input, it uses a brighter shade of the color for the fill. This doesn't look quite the same as the normal define block by comparison, although there isn't much else you can do for a custom color.