Don't use CSS cascade for high contrast theme - #515
Draft
tjvr wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the two Scratch 3.0 themes share a CSS file. The blocks use the same classes (e.g.
.sb3-motion), and we switch between themes by setting a class on the root SVG element, e.g.scratchblocks-style-scratch3-high-contrast.In #504 we discovered that Inkscape and other SVG editors do not handle this correctly. It would be nice to fix this!
The only way I can think to fix it is to avoid relying on the CSS cascade, and instead have entirely separate CSS classes, e.g.
.sb3-motionvs.sb3hc-motion. This change implements the fix in that way -- which does seem to keep Inkscape happy!