Ensure php7.4 compatibility#16
Merged
splitbrain merged 1 commit intosplitbrain:masterfrom Dec 12, 2019
usox:php74-compat
Merged
Ensure php7.4 compatibility#16splitbrain merged 1 commit intosplitbrain:masterfrom usox:php74-compat
splitbrain merged 1 commit intosplitbrain:masterfrom
usox:php74-compat
Conversation
splitbrain
requested changes
Dec 11, 2019
Owner
splitbrain
left a comment
There was a problem hiding this comment.
I believe, simply replacing the curly brackets with square brackets is faster than strpos. (I realize that this is a micro-optimization)
Contributor
Author
|
Hi
I think so, too - it was my first approach. But I guess there are many people out there who don't know about the array-like access to char positions in a string, so I chose strpos. |
Contributor
Author
|
Done |
Owner
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
Array and string offset access syntax with curly braces is deprecated in php 7.4 so I replaced it by strpos calls.
I also optimized the OptionTest a bit