Allow nosyslog with daemon mode.#1163
Open
aebrahim wants to merge 1 commit into
Open
Conversation
Member
|
This doesn't appear to make sense to me. If If After this change, there doesn't actually appear to be anyway to disable the syslog. |
Author
|
I confused store_true with a bool arg - I'll update. Thanks for looking |
brianmay
requested changes
May 25, 2026
brianmay
left a comment
Member
There was a problem hiding this comment.
Changes as discussed.
argparse.BooleanOptionalAction might be better choice maybe?
Assuming that works :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will still default to true if daemon is specified, but now we can allow specification of no syslog with daemon mode.