Conversation
|
This PR and possibly this branch will need updating once #405 is merged, but in the meantime it should be possible to review it. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@syoyo Ready for review |
There was a problem hiding this comment.
Pull request overview
Updates the Python packaging/CI configuration to align with newer packaging metadata expectations (SPDX-style license metadata) and to build wheels with cibuildwheel v3.3.1 in GitHub Actions.
Changes:
- Remove deprecated license classifiers from
setup.pyand add explicit license metadata inpyproject.toml. - Add
tool.cibuildwheelconfiguration topyproject.tomland bump GitHub Actions topypa/cibuildwheel@v3.3.1. - Adjust GitHub Actions wheel build selection to support the “quick build + test wheels” workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
setup.py |
Removes license classifiers from package metadata. |
pyproject.toml |
Adds license metadata and a global tool.cibuildwheel skip configuration. |
.github/workflows/python.yml |
Upgrades cibuildwheel action to v3.3.1 and changes wheel build/skip selectors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyproject.toml
Outdated
| # Disable aarch64 build since its too slow to build(docker + qemu). | ||
| skip = ["cp38-*", "cp314t-*", "*_aarch64*"] |
There was a problem hiding this comment.
[tool.cibuildwheel] skip is now global and includes "*_aarch64*", which will also disable the existing Linux aarch64 wheel build in Cirrus CI (see .cirrus.yml linux_aarch64_task running cibuildwheel). If aarch64 wheels are still intended to be published, move the aarch64 exclusion into the GitHub Actions workflow env for the slow QEMU job(s) (or set CIBW_ARCHS_LINUX=x86_64 there) rather than skipping aarch64 in pyproject.toml for all CI providers.
| # Disable aarch64 build since its too slow to build(docker + qemu). | |
| skip = ["cp38-*", "cp314t-*", "*_aarch64*"] | |
| # Disable some Python versions globally; architecture-specific exclusions should be configured in CI workflows. | |
| skip = ["cp38-*", "cp314t-*"] |
There was a problem hiding this comment.
We are not using Cirrus anymore so this isn't relevant.
| CIBW_ARCHS_WINDOWS: "AMD64" | ||
| # The quick build has already taken care of manylinux. |
There was a problem hiding this comment.
This change drops 32-bit wheel builds (Windows x86 and Linux i686) by removing them from CIBW_ARCHS_WINDOWS/CIBW_ARCHS_LINUX. If the project still supports 32-bit Python environments, this will be a packaging regression; either restore those arches or document/communicate the intentional support drop and ensure downstream release tooling expects fewer artifacts.
| CIBW_ARCHS_WINDOWS: "AMD64" | |
| # The quick build has already taken care of manylinux. | |
| CIBW_ARCHS_WINDOWS: "AMD64 x86" | |
| CIBW_ARCHS_LINUX: "x86_64 i686" | |
| # The quick build has already taken care of manylinux_x86_64 wheels. |
There was a problem hiding this comment.
These are deliberately removed.
|
@paulmelnikow There are some Copilot suggestions. Also please merge |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… into upgrade-cibw
This is a follow-on to #405 which needs to land first.