Skip to content

Command is executed in the wrong window!#77

Merged
tony merged 1 commit intotmux-python:masterfrom
ThiefMaster:fix-dash-t-command
Apr 1, 2014
Merged

Command is executed in the wrong window!#77
tony merged 1 commit intotmux-python:masterfrom
ThiefMaster:fix-dash-t-command

Conversation

@ThiefMaster
Copy link
Contributor

@ThiefMaster ThiefMaster commented Apr 1, 2014

I have this config (the echoes are just to avoid actually starting stuff while testing things).

After loading it, almost everything is fine except the ssh indico-lb-test command. It's entered (not executed, i.e. no ENTER after the command) in the first pane of window 4 (actually in whatever pane is focused in that window, when removing the focus entry it's started in another pane of that window).

session_name: main
windows:
  #1 - root
  -
    window_name: root
    panes:
      -
        shell_command:
          - sudo su -
          - tmux a || tmux
  #2 - indico
  - 
    window_name: indico
    layout: "98b6,317x91,0,0[317x8,0,0,1,317x82,0,9,2]"
    start_directory: ~/dev/indico/src
    focus: true
    panes:
      - echo tail -f ../data/log/indico.log
      -
        focus: true
        shell_command:
  #3 - dev-a
  - 
    window_name: dev-a
    start_directory: ~/dev/indico/src
    panes:
      - echo ssh indicodev-adrian
  #4 - puppet
  -
    window_name: puppet
    layout: tiled
    start_directory:  ~/dev/it-puppet-hostgroup-indico
    panes:
      -
        focus: true
        shell_command:
      -
        start_directory: ~/dev/it-puppet-module-indico_linux_goodies
        shell_command:
      -
        start_directory: ~/dev/it-puppet-hostgroup-jabber
        shell_command:
      -
        start_directory: ~/dev/it-puppet-hostgroup-indic8r
        shell_command:
  #5 - lb-test
  - 
    window_name: lb-test
    panes:
      - echo ssh indico-lb-test
  #6 - cernres
  - 
    window_name: cernres
    start_directory: ~/dev/indico-cern-resources
    panes:
      -
  #7 - aiadm
  - 
    window_name: aiadm
    panes:
      - echo ssh aiadm

@tony
Copy link
Member

tony commented Mar 31, 2014

@ThiefMaster

This needs to be isolated a bit more. What if it was just section 4 and 5?

Does changing shell_command: to pane help?

@ThiefMaster
Copy link
Contributor Author

ThiefMaster commented Apr 1, 2014

Ok, I found the issue. It's caused by a command containing -t. Here's a minimal case to reproduce it:

session_name: bug
windows:
  - window_name: a
    panes:
      -
  - window_name: b
    panes:
      - foo-t

With foo-bar it works fine, but as soon as as there's -t in it (no matter where) it starts failing.

@tony
Copy link
Member

tony commented Apr 1, 2014

Does wrapping it in single quotes give the same result?

On Tuesday, April 1, 2014, ThiefMaster notifications@github.com wrote:

Ok, I found the issue. It's caused by a command containing -t. Here's a
minimal case to reproduce it:

session_name: bug
windows:

  • window_name: a
    panes:

  • window_name: b
    panes:
    • foo-t

Reply to this email directly or view it on GitHubhttps://github.com//issues/77#issuecomment-39227437
.

@ThiefMaster
Copy link
Contributor Author

ThiefMaster commented Apr 1, 2014

Yey. Even - '"foo-t"' and - "'foo-t'" cause this issue.

Update: Found the problem. PR coming in a few minutes.

ThiefMaster
ThiefMaster reviewed Apr 1, 2014
View reviewed changes
tmuxp/window.py
Copy link
Contributor Author

@ThiefMaster ThiefMaster Apr 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests succeed, is there any case where arg wouldn't be a string?

Copy link
Member

@tony tony Apr 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThiefMaster I don't believe so.

@tony
Copy link
Member

tony commented Apr 1, 2014

@ThiefMaster: Let me know when you are done with the changes / PR's for the night. Do you still want to take a stab at #73 tonight or come back to it later?

@ThiefMaster
Copy link
Contributor Author

ThiefMaster commented Apr 1, 2014

Done for today!

tony added a commit that referenced this pull request Apr 1, 2014
@tony
Merge pull request #77 from ThiefMaster/fix-dash-t-command
803eb85 
Command is executed in the wrong window!
@tony tony merged commit 803eb85 into tmux-python:master Apr 1, 2014
tony added a commit that referenced this pull request Apr 1, 2014
@tony
Version 0.1.9, changes by @ThiefMaster #73, #76, #77.
0b880b7
@ThiefMaster ThiefMaster deleted the fix-dash-t-command branch April 2, 2014 00:24
@tony
Copy link
Member

tony commented Apr 2, 2014

@ThiefMaster: While you were resting, travis finished the tests and I went ahead and published these 3 patches as v0.1.9. Way to go!

http://tmuxp.readthedocs.org/en/latest/history.html

@ThiefMaster
Copy link
Contributor Author

ThiefMaster commented Apr 2, 2014

I think something went wrong with the merge (did you by any change perform an accidentally forced push after merging the PRs)?

> git lg -3 upstream/master
* 0b880b7 - (HEAD, tag: v0.1.9, upstream/master, origin/master, origin/HEAD, master) Version 0.1.9, changes by @ThiefMaster #73, #76, #77. (11 hours ago) <Tony Narlock>
* e19147e - tests: cli.py remove an unused config fixture. (35 hours ago) <Tony Narlock>
* 913aaaf - Add note about py34 in tox.ini, remove print() in helpers.py, clean up doc comment. (35 hours ago) <Tony Narlock>

@ThiefMaster ThiefMaster restored the fix-dash-t-command branch April 2, 2014 09:54
@tony
Copy link
Member

tony commented Apr 2, 2014

@ThiefMaster : I see you were able to restore the the branches, keep them there and I will re-merge them when I get back tonight? Sorry about that, it happened during the downtime yesterday https://status.github.com/messages.

tony added a commit that referenced this pull request Apr 2, 2014
@tony
Merge remote-tracking branch 'ThiefMaster/fix-dash-t-command' #77
6b04d3c
@tony
Copy link
Member

tony commented Apr 3, 2014

@ThiefMaster : v0.1.10 on pypi. Better now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThiefMaster @tony