Fix errors with start_directory containing spaces#73
Merged
tony merged 7 commits intotmux-python:masterfrom Apr 1, 2014
ThiefMaster:startdir-spaces
Merged
Fix errors with start_directory containing spaces#73tony merged 7 commits intotmux-python:masterfrom ThiefMaster:startdir-spaces
tony merged 7 commits intotmux-python:masterfrom
ThiefMaster:startdir-spaces
Conversation
Member
|
@ThiefMaster: Thanks for this, Can you take a look over https://travis-ci.org/tony/tmuxp/builds/21901819? |
Contributor
Author
|
Ugh, seems like tmux 1.8 and 1.9+ handle the start dir argument differently.. I'll have a look later when I'm not at work. |
It never checked if the start directory was properly set on the right window. Now it does.
tmux 1.9 removed the latter
Contributor
Author
|
Ok, they removed |
Member
|
@ThiefMaster : Thank gosh tmuxp has a testcases against multiple versions of tmux that actually asserts changes. |
tony
added a commit
that referenced
this pull request
Apr 1, 2014
Fix errors with start_directory containing spaces
tony
added a commit
that referenced
this pull request
Apr 1, 2014
tony
added a commit
that referenced
this pull request
Apr 2, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way you are passing arguments to the shell commands makes escaping of arguments unnecessary and doing so anyway breaks things. Also, the start_directory testcase was pretty broken and did not test if the correct directory was used.