Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
=======================================
Coverage 78.32% 78.32%
=======================================
Files 5 5
Lines 798 798
Branches 232 232
=======================================
Hits 625 625
Misses 115 115
Partials 58 58
Continue to review full report at Codecov.
|
Closed
Member
Author
|
@pythops Do you want to make your own pull request / redo the branch ? (So you get full credit for this?) I can wait as long as you'd like! No hurry! |
Contributor
|
@tony Just merge it :) |
Member
Author
|
@pythops Merged! Thank you for the contribution and the tests! I updated tests and switched it to use glob (since it's easier on package maintainers downstream, |
Contributor
|
@tony glad to contribute :) |
tony
added a commit
that referenced
this pull request
Dec 13, 2025
Adds a regression test documenting the fix for TmuxObjectDoesNotExist being raised when a session is killed while the user is attached. The issue was caused by libtmux's Session.attach() calling refresh() after attach-session returned. This was fixed in libtmux by removing the semantically incorrect refresh() call. Test uses NamedTuple + parametrize + test_id pattern per project style. Related: libtmux 9a5147aa (introduced bug), tmuxp fdafdd2 (triggered it) Fix: libtmux PR #616
tony
added a commit
that referenced
this pull request
Dec 13, 2025
Adds a regression test documenting the fix for TmuxObjectDoesNotExist being raised when a session is killed while the user is attached. The issue was caused by libtmux's Session.attach() calling refresh() after attach-session returned. This was fixed in libtmux by removing the semantically incorrect refresh() call. Test uses NamedTuple + parametrize + test_id pattern per project style. Related: libtmux 9a5147aa (introduced bug), tmuxp fdafdd2 (triggered it) Fix: libtmux PR #616
tony
added a commit
that referenced
this pull request
Dec 14, 2025
Adds a regression test documenting the fix for TmuxObjectDoesNotExist being raised when a session is killed while the user is attached. The issue was caused by libtmux's Session.attach() calling refresh() after attach-session returned. This was fixed in libtmux by removing the semantically incorrect refresh() call. Test uses NamedTuple + parametrize + test_id pattern per project style. Related: libtmux 9a5147aa (introduced bug), tmuxp fdafdd2 (triggered it) Fix: libtmux PR #616
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#599 rebased