A bunch of fixes - #155
Merged
Merged
Conversation
acpi.h is a pretty large header that contains a lot of structs. Don't include it by default to reduce header pollution. Users that actually need the tables in their translation unit should include acpi.h directly. Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
It would be leaked in case name_string_to_path failed to allocate the memory for the path backing. Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
1. NT does, in fact, respect the revision for ToInteger. What I saw earlier was just an artifact of how it prints out the traces in the amli debugger. 2. Concatenate has no reason to unconditionally pass 8, since the resulting buffer is truncated to sizeof_int() * 2 anyway. Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
Make sure they're unreferenced on failure. Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
Such packages are possible in case the creation code OOMs while attempting to fill a package with preallocated storage. Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.