[WIP] Add communication options to PuppetDB/Zabbix#41
Open
bastelfreak wants to merge 5 commits into
Open
Conversation
this commit provides a simple config handler which parses yaml files. We also provide a basic yaml config with values that we later need for our puppetdb/zabbix integration. gitignore gets extended to ignore the live config because it can contain sensitive data (we also extend the doc in virtapi_app.rb)
Member
Author
|
this is currently somehow broken: has anybody an idea why the include doesn't work? |
df9ccdd to
9e74b13
Compare
this is WIP and not working!
9e74b13 to
6f8de23
Compare
we now ship a YAML file so we should ensure that it works properly. This defines yamllinter in the Gemfile, loads and defines the Rake task and specifies the path to config/*.yml for linting
Member
Author
|
fixed the issue by changing the require order and fixing a typo in a filename |
two issues: the zabbix module file had the wrong name ( missing b) and the require in the virtapi_app had the wrong order
23fb69f to
1ee6fcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.