Unify <mark>'s UIA LocalizedControlType and AX AXRoleDescription - #235
Merged
scottaohara merged 1 commit intoSep 19, 2019
Merged
scottaohara merged 1 commit into
scottaohara merged 1 commit into
Conversation
…stent by changing both to 'highlight'
dandclark
marked this pull request as ready for review
September 6, 2019 16:27
Member
|
if Webkit will commit to implement, then this looks like a good change to me. Thank you |
scottaohara
approved these changes
Sep 6, 2019
Contributor
Author
@cookiecrook , is this something you'd be able to comment on? |
|
@cookiecrook Any update here? Thanks :) |
Collaborator
|
Seems like a good change. WebKit bugzilla link above was broken, and I didn’t find an existing bug, so I filed a new one: |
Collaborator
|
PS. Looks like the Gecko link is also broken. |
Contributor
Author
|
I updated the link to the WebKit bug and removed the broken Gecko link |
Member
|
thanks everyone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://w3c.github.io/html-aam/#el-mark, the UIA LocalizedControlType for
<mark>is "mark" while the AXRoleDescription is "highlighted content". There is no good reason for these values to be different; this adds complexity for implementers and creates confusion for users when moving across platforms. Furthermore, "mark" is a confusing name for non-programmers, and "highlighted content" is unnecessary verbose.This change switches both role descriptions to "highlight", removing the inconsistency and improving upon both existing names.
Closes #236
The following tasks have been completed:
Implementation commitment:
CC: @aleventhal @cookiecrook @boggydigital
Preview | Diff