Improve Group Policy installer error details#27300
Open
badgerbees wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Group Policy installer script to emit more actionable error messages when ADMX/ADML copy verification fails, by including the destination path in the failure text.
Changes:
- Include
$admxTargetFullPathin the ADMX install failure message. - Include
$admlTargetFullPathin the ADML install failure message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This updates
InstallPSCorePolicyDefinitions.ps1so the ADMX and ADML install failure messages include the destination path they were trying to write to. The behavior is unchanged; the terminal output is just more actionable when the copy verification fails.PR Context
The existing failure messages only say that the files could not be installed, which leaves out the target path and makes troubleshooting harder. This change adds the missing diagnostic detail without changing the install flow. I verified the updated error text by running a sandboxed copy of the script and forcing the failure path.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header