Fix progress bar accumulation in Minimal view#27367
Open
reabr wants to merge 8 commits into
Open
Conversation
Also caps rendered bars to 5 in Minimal mode as a safety net. Fixes PowerShell#26915
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a performance/usability issue in the ConsoleHost Minimal/ANSI progress renderer where progress nodes could accumulate indefinitely, causing excessive re-rendering and console output (O(N²)) when many activities reach 100% without sending -Completed.
Changes:
- Update
PendingProgressto remove 100%-complete progress nodes in Minimal view and cap rendered top-level bars to 5. - Add Pester coverage intended to exercise the Minimal progress view behavior around accumulation/capping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/Microsoft.PowerShell.ConsoleHost/host/msh/PendingProgress.cs |
Removes 100% nodes in Minimal view and caps rendered top-level nodes to reduce output/perf impact. |
test/powershell/Modules/Microsoft.PowerShell.Utility/Write-Progress.Tests.ps1 |
Adds new Pester tests targeting Minimal progress view scenarios. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Minimal/ANSI progress rendering mode, completed progress bars
were never removed from the internal tree, causing O(N²) console
output flooding when many bars reach 100% (e.g. Azure blob downloads).
Changes
PendingProgress.cs: Auto-remove nodes when PercentCompletereaches 100 in Minimal mode
PendingProgress.cs: Cap rendered bars to 5 in Minimal modeas a safety net
Write-Progress.Tests.ps1: Added 3 new tests covering the fixFixes
Fixes #26915