[bug] Fixed test_invalid_instruction always reporting failure#513
Open
es3n1n wants to merge 2 commits into
Open
[bug] Fixed test_invalid_instruction always reporting failure#513es3n1n wants to merge 2 commits into
es3n1n wants to merge 2 commits into
Conversation
The x86 test file already defines this macro for the commented-out failure block; mirror it on the x64 side so future PRs can add FAIL_INSTRUCTION(...) cases inline without reintroducing the macro each time.
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssemblerTester::test_invalid_instructioninasmjit_test_assembler.hhas a second guardif (err != Error::kOk)right after an early return onerr == kOk, so it's always true and everyFAIL_INSTRUCTION(...)call prints "failed with X, but should have failed with Y" even when the errors match