test: introduce awaitility to sdk-platform-java#13458
Merged
blakeli0 merged 5 commits intoJun 15, 2026
Merged
Conversation
Introduces awaitility version 4.3.0 to gapic-generator-java-pom-parent and gax-java, and migrates ThresholdBatcherTest to use it with 1 second timeouts instead of brittle Thread.sleep.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the Awaitility library to replace Thread.sleep calls with asynchronous assertions in ThresholdBatcherTest.java, improving test reliability. The review feedback points out a critical build issue in gax-java/pom.xml where the ${awaitility.version} property is undefined, and recommends increasing the await timeout from 1 second to 5 seconds in the tests to prevent flakiness in resource-constrained CI environments.
lqiu96
approved these changes
Jun 12, 2026
9397b32 to
0643d31
Compare
blakeli0
added a commit
that referenced
this pull request
Jun 17, 2026
…ts (#13484) This PR migrates all remaining wait loops and polling blocks in GAX tests to use Awaitility. This is the second part of b/505479343, following the initial introduction of Awaitility in #13458. Specifically, this migrates: - Semaphore64Test: replaced mock thread wait loops with Awaitility state waiting. - ScheduledRetryingExecutorTest: migrated future attempt checking, attempt cancellation wait, and first attempt latch count down to Awaitility. - BatcherImplTest: converted GC loops and thread state polling blocks to Awaitility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
This is the first PR of b/505479343. Follow up PRs would migrate all tests in sdk-platform-java to use awaitility.