Conversation
Contributor
Test Results 326 files 326 suites 4m 57s ⏱️ Results for commit 45620c0. |
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 45620c0. ♻️ This comment has been updated with latest results. |
bbakerman
approved these changes
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow 9.0 is a major breaking change and a total rewrite, which has meant our JMH jar didn't work in our performance pipeline
This tries to re-create the old behaviour of creating a fat JAR
I've confirmed this works by running the performance pipeline on this branch. You can see the results checked in here: dcafe23
Shadow 9.0 is not the latest version, trying to keep the version difference small for this bump