MinioAdminClient: add methods (attachPolicies, detachPolicies) - #1626
Closed
jongminchung wants to merge 4 commits into
Closed
MinioAdminClient: add methods (attachPolicies, detachPolicies)#1626jongminchung wants to merge 4 commits into
jongminchung wants to merge 4 commits into
Conversation
harshavardhana
requested review from
balamurugana
and removed request for
balamurugana
February 13, 2025 08:34
balamurugana
requested changes
Feb 14, 2025
balamurugana
left a comment
Member
There was a problem hiding this comment.
Refer https://github.com/minio/minio-py/blob/master/minio/minioadmin.py#L97 to implement ldap/builtin commands as they use same logic
Contributor
Author
|
Should I include ldap command in that MR?
|
Member
|
Handled in #1621 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resovles #1625