Skip to content

doc: update Http2Server.close & Http2SecureServer.close#63298

Open
samuel871211 wants to merge 1 commit into
nodejs:mainfrom
samuel871211:close
Open

doc: update Http2Server.close & Http2SecureServer.close#63298
samuel871211 wants to merge 1 commit into
nodejs:mainfrom
samuel871211:close

Conversation

@samuel871211
Copy link
Copy Markdown
Contributor

@samuel871211 samuel871211 commented May 14, 2026 •
edited
Loading

https://github.com/nodejs/node/blob/main/lib/internal/http2/core.js#L3505

  close() {
    ReflectApply(NETServer.prototype.close, this, arguments);
    closeAllSessions(this);
  }

Related PR: #57586

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 14, 2026

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels May 14, 2026
mcollina
mcollina approved these changes May 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samuel871211
doc: update Http2Server.close & Http2SecureServer.close
72b995d 
Signed-off-by: Yu-Sheng Chen <samuel871211@gmail.com>
samuel871211
samuel871211 commented May 16, 2026
View reviewed changes
Comment thread doc/api/http2.md
[`http2.Server`]: #class-http2server
[`http2.createSecureServer()`]: #http2createsecureserveroptions-onrequesthandler
[`http2.createServer()`]: #http2createserveroptions-onrequesthandler
[`http2session.close()`]: #http2sessionclosecallback
Copy link
Copy Markdown
Contributor Author

@samuel871211 samuel871211 May 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHY？

Because：

https://github.com/nodejs/node/actions/runs/25840207727/job/76301962849

doc/api/http2.md
5031:1-5031:53 warning Unexpected unused definition, expected no definition or one or more references to http2session.close() no-unused-definitions remark-lint

⚠ 1 warning
make: *** [Makefile:1464: tools/.mdlintstamp] Error 1
Error: Process completed with exit code 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@pimterry pimterry pimterry approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@samuel871211 @nodejs-github-bot @mcollina @lpinca @pimterry @UlisesGascon @Ethan-Arrowood