Match signer chosing to algorithm registry - #1027
Merged
Merged
Conversation
- Don't allow any arbitrary signer implementation - Have the user select from a curated list - We still only support sha256 for now - Verification is unchanged for now in that we will parse the key instead of reading key details Signed-off-by: Appu Goundan <appu@google.com>
vlsi
approved these changes
Jul 22, 2025
loosebazooka
marked this pull request as ready for review
July 22, 2025 15:10
aaronlew02
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start integrating algorithm registry into sigstore-java.
KeylessSigner.signer(any impl)is now replaced withKeylessSigner.singer(AlgorithmRegistry.SigningAlgorithm)No changes were made to how verification parses and operates on keys
Sigstore java still requires sha256 as the hashing algorithm across operations.
Release Note
Documentation