Add RFC3161 timestamps to keyless signer and verifier - #979
Merged
Conversation
aaronlew02
force-pushed
the
timestamp-keyless
branch
from
June 4, 2025 17:58
b979591 to
dd14cf4
Compare
loosebazooka
reviewed
Jun 4, 2025
aaronlew02
force-pushed
the
timestamp-keyless
branch
2 times, most recently
from
June 4, 2025 18:40
1e939e9 to
0cbeba6
Compare
loosebazooka
reviewed
Jun 4, 2025
aaronlew02
force-pushed
the
timestamp-keyless
branch
2 times, most recently
from
June 5, 2025 14:22
a4ee8a7 to
579c8d5
Compare
loosebazooka
reviewed
Jun 5, 2025
loosebazooka
left a comment
Member
There was a problem hiding this comment.
LGTM, just that minor refactoring.
loosebazooka
reviewed
Jun 5, 2025
loosebazooka
reviewed
Jun 5, 2025
loosebazooka
reviewed
Jun 5, 2025
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
aaronlew02
force-pushed
the
timestamp-keyless
branch
from
June 5, 2025 15:56
579c8d5 to
3df4c8d
Compare
loosebazooka
approved these changes
Jun 5, 2025
loosebazooka
left a comment
Member
There was a problem hiding this comment.
cool, lets enable the conformance test that used timestamps now that this is in?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #959 and thus closes #699
Summary
This change allows for the
KeylessSignerto add RFC3161 timestamps to a bundle andKeylessVerifierto verify such timestamps.