Fix: always prompt when closing a single SQL tab with unsaved content…#4141
Open
Negi2110 wants to merge 1 commit into
Open
Fix: always prompt when closing a single SQL tab with unsaved content…#4141Negi2110 wants to merge 1 commit into
Negi2110 wants to merge 1 commit into
Conversation
…sqlitebrowser#4128) When closing an individual SQL tab that belongs to a project, the save prompt was gated behind the 'promptsqltabsinnewproject' preference. This meant users with that setting disabled could accidentally close tabs and lose work silently. Fix: pass singleTabClose=true from closeSqlTab() to askSaveSqlTab(), bypassing the preference check for individual tab closes. The preference still applies when closing the whole app/project (closeFiles path).
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4128
Problem
When closing an individual SQL tab that belongs to a saved project,
the save prompt was gated behind the
promptsqltabsinnewprojectpreference setting. If a user had that setting disabled, closing a
single tab would silently discard its content with no warning.
The root cause:
askSaveSqlTab()was called the same way whetherclosing the entire app (bulk path via
closeFiles()) or closing asingle tab (via
closeSqlTab()). The preference makes sense forthe bulk path but not for a deliberate single-tab close.
Fix
Added a
singleTabCloseparameter (defaultfalse) toaskSaveSqlTab(). WhencloseSqlTab()calls it, it passestrue,bypassing the preference check and always prompting if the tab
has unsaved content. The
closeFiles()bulk path is unchanged.How to test