Repository navigation
Align select-family conversion and timeouts - #9663
Closed
youknowdot wants to merge 1 commit into
Closed
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Reuse signed pytime conversion and descriptor/argument binding across select, poll, epoll and kqueue. Preserve conversion order, argument roots, timeout bounds and rounding, and poll event masks. Use ppoll where supported for nanosecond deadlines. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Member
|
todo: need review |
youknowdot
added a commit
to youknowdot/RustPython
that referenced
this pull request
Nov 6, 2026
Incorporate RustPython#9663 intact alongside the thread timeout fixes, retaining its commit and attribution. Assisted-by: OpenAI Codex:model version not exposed
Contributor
Author
|
Consolidated into #9652 at 8e59835. This original commit is preserved as an ancestor, including descriptor conversion, callback ordering, ppoll precision, and retry-budget handling. The combined branch passed 533 targeted timeout regression tests plus the thread audit test; full aggregate checks and exact-head CI remain pending. Closing this duplicate without deleting its branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Group the related select-family conversion and timeout fixes around the VM's existing signed
pytimeconversion, rather than maintaining another conversion implementation.Fildesand derived raw argument binding. Preserve argument roots and callback/error ordering for select, poll, epoll, and kqueue.No test or snippet edits. The overlaps with #9652's separate thread-timeout additions and #8954's C-API time helpers were checked by clean three-way compositions of
pytime.rs.Reference
Compared against CPython v3.15.0
Modules/selectmodule.c, its Clinic bindings, andPython/pytime.c.Validation
cargo check --offline: passed.cargo clippy --offline -- -D warnings: passed.git diff --check, and normal repository pre-commit hooks: passed.Platform-specific kqueue, Windows, and 32-bit paths are source-reviewed, not runtime-validated. The pre-existing epoll signal-handler-close locking behavior remains outside this conversion patch. A 32-bit ppoll time_t overflow retains a generic timeout-overflow diagnostic.
AI assistance
OpenAI Codex assisted with source comparison, implementation, review, and validation. The model version is not exposed by this environment.