cleanup: remove redundant providedIn root declarations in Injection Tokens#64802
Merged
atscott merged 5 commits intoangular:mainfrom Nov 4, 2025
Merged
Conversation
…tokens Removes unnecessary `providedIn: 'root'` declarations from injection tokens
Contributor
Author
|
Should we group the changes into a single PR with multiple commits, since I see something similar in other packages? |
Member
|
Yeah lets do a single PR. A single commit can be fine targeting "core", as this is a "core" api usage. |
… tokens Removes unnecessary `providedIn: 'root'` declarations from injection tokens
…n tokens Removes unnecessary `providedIn: 'root'` declarations from injection tokens
… injection tokens Removes unnecessary `providedIn: 'root'` declarations from injection tokens
…m injection tokens Removes unnecessary `providedIn: 'root'` declarations from injection tokens
providedIn: 'root' from injection …
JeanMeche
approved these changes
Oct 30, 2025
Contributor
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the following commits :
refactor(core): remove redundant providedIn: 'root' from injection tokens
refactor(forms): remove redundant providedIn: 'root' from injection tokens
refactor(router): remove redundant providedIn: 'root' from injection tokens
refactor(platform-server): remove redundant providedIn: 'root' from injection tokens
refactor(platform-browser): remove redundant providedIn: 'root' from injection tokens
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information