Skip to content

refactor(common): remove redundant providedIn: 'root' from injection …#65057

Merged
AndrewKushnir merged 1 commit intoangular:mainfrom
SkyZeroZx:refactor/remove-root
Dec 12, 2025
Merged

refactor(common): remove redundant providedIn: 'root' from injection …#65057
AndrewKushnir merged 1 commit intoangular:mainfrom
SkyZeroZx:refactor/remove-root

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Nov 10, 2025

Redundant statements that were missing were removed

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from JeanMeche November 10, 2025 19:21
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Nov 10, 2025
@ngbot ngbot bot added this to the Backlog milestone Nov 10, 2025
@JeanMeche
Copy link
Member

Caretake: This is a follow-up of #64802. A token with a factory is implictly providedIn in root unless specified otherwise

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 11, 2025
@AndrewKushnir AndrewKushnir added action: discuss and removed action: merge The PR is ready for merge by the caretaker labels Nov 11, 2025
@JeanMeche JeanMeche added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Nov 20, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker action: discuss and removed action: discuss action: merge The PR is ready for merge by the caretaker labels Nov 20, 2025
@SkyZeroZx SkyZeroZx force-pushed the refactor/remove-root branch from 7ccc0b6 to 60992d7 Compare December 4, 2025 18:46
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: discuss labels Dec 5, 2025
@thePunderWoman thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Dec 10, 2025
@thePunderWoman
Copy link
Contributor

@SkyZeroZx This has file conflicts that need addressing.

…tokens

Removes unnecessary declarations from injection tokens
@SkyZeroZx SkyZeroZx force-pushed the refactor/remove-root branch from 60992d7 to db37992 Compare December 10, 2025 22:17
@angular-robot angular-robot bot requested a review from JeanMeche December 10, 2025 22:17
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 10, 2025
@thePunderWoman thePunderWoman removed the request for review from JeanMeche December 10, 2025 23:45
@AndrewKushnir AndrewKushnir merged commit 8485579 into angular:main Dec 12, 2025
20 checks passed
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants