remove redundant root in IDLE_SERVICE and document @defer new option#67444
Open
SkyZeroZx wants to merge 2 commits intoangular:mainfrom
Open
remove redundant root in IDLE_SERVICE and document @defer new option#67444SkyZeroZx wants to merge 2 commits intoangular:mainfrom
root in IDLE_SERVICE and document @defer new option#67444SkyZeroZx wants to merge 2 commits intoangular:mainfrom
Conversation
…ICE` Remove the `providedIn: 'root'` configuration from the `IDLE_SERVICE` token since it is redundant and does not change the default injection behavior
root in IDLE_SERVICE and document @defer new optionroot in IDLE_SERVICE and document @defer new option
| } | ||
|
|
||
| export const IDLE_SERVICE = new InjectionToken<IdleService>(ngDevMode ? 'IDLE_SERVICE' : '', { | ||
| providedIn: 'root', |
Contributor
There was a problem hiding this comment.
Why are we removing this?
Contributor
Author
There was a problem hiding this comment.
According to InjectionToken, the default is root
angular/packages/core/src/di/injection_token.ts
Lines 111 to 115 in 6267626
Also similar to a previous cleanup #65057
Contributor
There was a problem hiding this comment.
Ah I see. Thanks for the clarification. REQUEST CHANGES!!!!
JKJK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@defer idle