docs(pm-dispatch): runbook patrol names the per-seat patrol and dedupes review claims by seat - #28759

domain:skills#2 · marchtian · session_017ihL2g7RyXa8ErM6GAkHyc

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 640da545520f11f7da2eef68839b7048ad61922b
Local-runs: none
Scope: .claude/skills/pm-dispatch/references/dispatch-runbook.md + .claude/skills/pm-dispatch/SKILL.md (L72, L303–309), references/seat-lifecycle.md (L8–13, L29, L41), references/contract-review.md (L20–28, L43–46, L56–60), references/cross-repo-coordination.md (L13–14), references/lanes/director.md (L7, L23, L74), scripts/pm/record-recognisers.mjs (CONTRACT_REVIEW_CLAIM_TEMPLATE, readContractReviewClaim), scripts/pm/check-owed-reviews.mjs (header, WAITING_LABEL), scripts/pm/post-stamped.mjs (signature contract, L471) — all read, none reviewed.

Inputs: card #28740 body and its three comments (triage 6561015247, claim 6561613036, dev report 6561774263); PR #28759 body, file list (one file, +3/−3) and the net diff against main at the head; the check-runs on the head. Remainder of the diff outside hits: none — the whole diff is the rules face.

① Derived judgments

• Accept set / public surface: none changes. One file under .claude/**; no package, exports, schema, CLI or docs path in the committed tree. Right.
• Face: reviewFace hits = the runbook (governed path) ⇒ rules face, CONTRACT_REVIEW_TIER. Tier S by the register; triage's Tier H plus maintainer approval as the ruling for a rule-text change is the stricter path the claim took. Right.
• Line ratchet: 245 → 245 lines (read from both trees), net 0; byte widths of the three changed lines read from the head tree 50 / 108 / 119 B, cap 120. Right.
• 每项目巡查: zero hits over the whole tree at the head (git grep on the branch). Right.
• lanes/director.md L74 cites the section by its name 巡查常设项, which the heading keeps; the parenthetical only changed. Still resolves. Right.
• Gates: the head's check-runs read at 2026-11-01T18:14Z — see the line below ④; every derived family on the head concluded success, none failure, none pending at the read; the remaining runs are skipped (no product path touched, so core/UI/docs/E2E/changeset/size shards do not fire).

② Semver level

skip-changeset label on the PR, Clause-②: no, Metadata-protocol: none on the body — matches the diff: nothing publishes, no metadata an author writes changes. Right.

③ Boundary flags

• open_questions Q1 (add the seat number to the claim form?) — A, leave it. The seat is already machine-readable on every seat-written comment: post-stamped.mjs refuses any body that does not open with LANE#N · ACCOUNT · SESSION, and every first-line reader in record-recognisers.mjs / check-half-states.mjs strips exactly one such signature line before reading the key line. A new field is out of this card's wording-only scope and would be a second spelling of a fact the signature already carries. (The card-claim template in SKILL.md L309 even has Seat: for cards; the review claim has a different line — see ④ should-fix 1.)
• Dev deviation 1 (PR body ends with the generated-with line, not the session-URL footer): accepted, not escalated — the body carries the project-thread link and the fleet attribution; no gate or recogniser reads the footer.
• Dev deviation 2 (attribution HTML comment as the body's first line): the harness/seat attribution exception; fine.
• Author: PR user.login is objectstack-fleet[bot] ⇒ no author note owed.
• Dev report said CI was in progress and not awaited: answered by the gate reading in ① — all concluded, none red.

④ Design judgment

.claude/skills/pm-dispatch/references/dispatch-runbook.md 〈巡查常设项〉, judged against the per-seat patrol it teaches and the double-review scenario the card accepts it against (one account sitting spec#4, devx#2 and skills#2 in one project).

• L39 heading 「每席巡查与总监席摘要」 — holds. SKILL.md L72 (每席一个自建自绑巡查 routine,总监席除外) and seat-lifecycle.md L41 (坐席同笔建自绑巡查 routine) are per seat; the director has no routine (director.md L7, L23), so 每席巡查 reads as every non-director seat while the director's items in the same section stay under 总监席摘要. Consistent.
• L44 「每席巡查跑 …,剔除本账户署名的 PR」 — holds, and keeping the self-exclusion account-keyed is right: (a) a PR's 署名 is its attribution login (claude-projects-attribution / Requested by), there is no seat number on a PR to key on; (b) this item is the 跨账户 backstop, not the owed review — the owed review of a same-account PR stays with its dispatching seat in-seat (contract-review.md L20, L26–28 车道胜) and, failing that, with triage under (a)(b)(c), a different account — so excluding sibling seats of one account opens no coverage gap; (c) it is stricter than, not contrary to, the agent-level independence contract-review.md L45–46 requires of the record pair. I tried the opposite reading (seat-keyed exclusion, letting devx#2 patrol-review skills#2's PR): permitted by L46 but it buys nothing the lane seat's own in-seat review does not already give, and it would need a seat on the PR that is not there.
• L45 「已有他席认领即跳过(同账户亦然)」 — holds. This is exactly the hole the card names: under 他账户, two seats of one account both passed the dedupe. 他席 is the vocabulary cross-repo-coordination.md L13–14 already uses for another seat's claim, and the seat is read off the enforced signature line, so no new field is needed. Net 0, no gate touched.

Findings (none must-fix):

• should-fix 1 — L45 still names the review claim as a Claim: 形评论(会话、账户), i.e. the card-claim form (SKILL.md L303). The review claim contract-review.md L26–28 defines, and record-recognisers.mjs pins verbatim (Contract-review-claim: session · head full sha · UTC, lapses on a moved head or after 2 h, lane wins a tie), is a different line: readContractReviewClaim returns missing for a Claim: comment, so check-owed-reviews.mjs prints claim: none and a reviewer following contract-review.md does not see the runbook-form claim — the ⛔ 不双做 then rests on prose reading alone. The key also differs at the edge: 他席 lets a new session of the same seat proceed, contract-review.md L26 says any live claim ⇒ do not start (runbook L46 defers to it). Pre-existing on main, not introduced or widened by this diff, and outside the card's three wordings — so not a FAIL here; the line should point at contract-review.md's claim line and lapse, keeping 「他席(同账户亦然)」 as the read of that line's signature. Worth a card on the skills lane, net 0.
• should-fix 2 — L44's read is the label search alone (label:needs:contract-review), while contract-review.md L25 names check-owed-reviews.mjs as the owed list (faces owed without the label, hand-off lines, holds, lapsed claims). A patrol that only searches the label misses a face-owed PR nobody labelled. Pre-existing, unchanged here; fold into the same card.

Gate read (head check-runs, 2026-11-01T18:14Z): Lint · PM dispatch-gates, Lint · docs & code guards, Lint · CI, release & engine gates, Lint · repo & tooling gates, Lint · ESLint, Type Check · source gates, Type Check · debt ledger, Type Check · consumer gates, Type Check · workspace, Governed Surface Queue Guard, PR-body guards, Lint & Repo Gates and the other derived runs — 23 runs completed / success; 22 runs skipped by path; 0 failure, 0 pending.

Implemented-by: claude/issue-28740-runbook-patrol-per-seat
Reviewed-by: session_017ihL2g7RyXa8ErM6GAkHyc

VERDICT: PASS

domain:skills#2 · marchtian · session_017ihL2g7RyXa8ErM6GAkHyc

维护者速读(席位终稿 · head 640da545520f11f7da2eef68839b7048ad61922b)

• 改了什么:dispatch-runbook.md 〈巡查常设项〉三行措辞:标题和跨账户复审行改为「每席巡查」;复核认领去重改为「已有他席认领即跳过(同账户亦然)」。
• 为什么改:feat(pm): a project seat's patrol is part of seating, recorded on the stub, and its absence is a half-state reading #28687、docs(pm-dispatch): one patrol routine per seat, not per project #28739 之后,巡查按席位一个;runbook 还写每项目一个。同一账户坐多个席位时,按账户去重挡不住两个席位重复复核同一 PR。
• 风险与回滚:只改三行文字,行数不变(245 → 245),无代码。回滚 = revert。
• 先看:.claude/skills/pm-dispatch/references/dispatch-runbook.md 第 39、44、45 行。
• 两分钟验证:git grep 每项目巡查 全仓无命中。
• 需要你做的:批准本 PR(规则变更以你的批准为裁决)。契约复审 PASS:6561911910(Head-sha: 640da545520f11f7da2eef68839b7048ad61922b)。

席位意见:ACCEPT.

席位核对

• 形态: 1 file, +3/−3, net 0. Bytes 50/108/119 against the 120 cap. skip-changeset, Clause-②: no, Metadata-protocol: none on body and claim (6561613036).
• 复审: CONTRACT_REVIEW_TIER PASS 6561911910, 0 must-fix. ④ judged L44's account-keyed self-exclusion right (a PR's 署名 is its attribution login; there is no seat on a PR to key on).
• 门禁: dev's dispatch-gates --commands 17/17 exit 0, --ran 0 NOT-MEASURED. Check-runs on 640da54552: 23 success, 22 skipped, 0 failure, none pending (record 6561911910).
• open_questions: Q1 (add a seat number to the claim form) → A, leave it: the seat is already machine-read from the signature line post-stamped.mjs enforces.
• 接受的偏差: PR footer is the 🤖 form with the session in body prose; no PR assignee — as on docs(pm-dispatch): one patrol routine per seat, not per project #28739.
• 范围外去向: review should-fixes SF-1 (L45 spells the review claim as a Claim: comment, not Contract-review-claim:) and SF-2 (L44 reads owed reviews off the label, not check-owed-reviews.mjs). Both were on main before this PR. Filed as pm-dispatch(runbook): 〈巡查常设项〉 spells the review claim as a Claim: comment and reads owed reviews off the label alone #28763, blocked by pm-dispatch(runbook): 〈巡查常设项〉 still names the patrol per project, and its cross-account review dedupe is keyed to the account #28740. Skills-docs: none — internal tooling.
• 落地条款: Tier S by the register, plus the card-level condition used for pm-dispatch: a project seat can sit with no hourly patrol routine and nothing notices — make the patrol a step of seat-online, record it in the seat post, and flag an on-duty lane's unclaimed pm:queue card #28642/pm-dispatch(mailbox): name when a seat MUST ring another — unblocked card, main-red anchor, release blocker, a question for triage, serial order, a relayed ruling — and close the seats with no mailbox #28675/pm-dispatch: SKILL.md says one patrol routine per project, the references now say one per seat — pick the seat #28699/pm-dispatch(mailbox): epic seats cannot be rung — mailbox-open refuses epic: seat keys and the fleet roster has no epic rows #28718. The PR stays draft with needs-user-decision until an authorised approver acts.