Skip to content

Cache AllOutX volume#975

Merged
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:cache_all_out_volume
Feb 18, 2021
Merged

Cache AllOutX volume#975
dwhswenson merged 2 commits into
openpathsampling:masterfrom
dwhswenson:cache_all_out_volume

Conversation

@dwhswenson

@dwhswenson dwhswenson commented Feb 17, 2021

Copy link
Copy Markdown
Member

There is no reason to create a new volume every time we use AllOutXEnsemble.can_append etc.

@dwhswenson dwhswenson mentioned this pull request Feb 17, 2021
Closed
@codecov

codecov Bot commented Feb 17, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #975 (4b0da5f) into master (19318c4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files         136      136           
  Lines       14449    14452    +3     
=======================================
+ Hits        11596    11599    +3     
  Misses       2853     2853
Impacted Files Coverage Δ
openpathsampling/ensemble.py 84.55% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19318c4...4b0da5f. Read the comment docs.

@dwhswenson

dwhswenson commented Feb 17, 2021

Copy link
Copy Markdown
Member Author

This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Thu 18 Feb 17:00 GMT (18:00 local).

@sroet

sroet commented Feb 17, 2021

Copy link
Copy Markdown
Member

looks fine by me, what was the issue that was solved in commit 4b0da5f ? (just interested, don't block this PR on that question)

@dwhswenson

dwhswenson commented Feb 17, 2021

Copy link
Copy Markdown
Member Author

what was the issue that was solved in commit 4b0da5f ?

Codecov complained and then didn't report coverage. Image below (since GH Actions doesn't archive logs long term).

image

@dwhswenson dwhswenson merged commit 3f2c0c4 into openpathsampling:master Feb 18, 2021
@dwhswenson dwhswenson deleted the cache_all_out_volume branch February 18, 2021 17:24
@sroet sroet mentioned this pull request Feb 19, 2021
Merged
@dwhswenson dwhswenson mentioned this pull request Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

misc PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwhswenson @sroet