Skip to content

also cache the ~volume for PartOutX#976

Merged
dwhswenson merged 1 commit into
openpathsampling:masterfrom
sroet:also_cache_partoutx
Feb 19, 2021
Merged

also cache the ~volume for PartOutX#976
dwhswenson merged 1 commit into
openpathsampling:masterfrom
sroet:also_cache_partoutx

Conversation

@sroet

@sroet sroet commented Feb 19, 2021

Copy link
Copy Markdown
Member

While diving further down with #892 I saw a similar solution as #975 for PartOutX. This also caches that volume

@codecov

codecov Bot commented Feb 19, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #976 (da38492) into master (3f2c0c4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #976   +/-   ##
=======================================
  Coverage   80.25%   80.26%           
=======================================
  Files         136      136           
  Lines       14452    14455    +3     
=======================================
+ Hits        11599    11602    +3     
  Misses       2853     2853
Impacted Files Coverage Δ
openpathsampling/ensemble.py 84.59% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2c0c4...da38492. Read the comment docs.

@sroet

sroet commented Feb 19, 2021

Copy link
Copy Markdown
Member Author

@dwhswenson the coverage drop seems unrelated? Anyway, this is ready for a review

dwhswenson
dwhswenson approved these changes Feb 19, 2021
View reviewed changes

@dwhswenson dwhswenson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably add a small allowance for flaky coverage. Re-running fixed.

BTW, tonight I'm playing with managing GitHub stuff from the phone, so if my tone differs, that's why.

@dwhswenson dwhswenson merged commit 82d5948 into openpathsampling:master Feb 19, 2021
@sroet sroet deleted the also_cache_partoutx branch February 19, 2021 20:50
@sroet

sroet commented Feb 19, 2021

Copy link
Copy Markdown
Member Author

BTW, tonight I'm playing with managing GitHub stuff from the phone, so if my tone differs, that's why.

Cool, good luck. I will be opening an interesting PR later tonight (should reduce the number of Trajectory objects that are generated by 75% (for my test system))

@dwhswenson dwhswenson mentioned this pull request Feb 22, 2021
Closed
@dwhswenson dwhswenson mentioned this pull request Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwhswenson dwhswenson dwhswenson approved these changes

Assignees

No one assigned

Labels

misc PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sroet @dwhswenson