Cppcheck suggested performance improvement#7
Closed
neuralsandwich wants to merge 1 commit intotinyobjloader:masterfrom
neuralsandwich:master
Closed
Cppcheck suggested performance improvement#7neuralsandwich wants to merge 1 commit intotinyobjloader:masterfrom neuralsandwich:master
neuralsandwich wants to merge 1 commit intotinyobjloader:masterfrom
neuralsandwich:master
Conversation
variables should be passed by reference. They are passed by value. It could be passed as a (const) reference which is usually faster and recommended in C++. This gives a 9% performance boost in my project. 26.28s to load instead of 28.94s
Collaborator
|
Cool! Merged. Thanks a lot! |
dgrat
pushed a commit
to dgrat/tinyobjloader
that referenced
this pull request
Nov 1, 2020
Development->Master Modifed README and LICENSE
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cppcheck suggests:
variables should be passed by reference.
They are passed by value. It could be passed as a (const) reference which is usually faster and recommended in C++.
This gives a 9% performance boost in my project.
26.28s to load instead of 28.94s